Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant UNF sub-option in JSON example #2418

Merged
merged 1 commit into from
Feb 21, 2023

Conversation

uglide
Copy link
Contributor

@uglide uglide commented Feb 21, 2023

UNF option is not required with JSON and makes the example harder to read and understand.

Description

Describe your pull request here


Checklist

  • Does npm test pass with this change (including linting)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

UNF option is not required with JSON and makes the 
example harder to read and understand.
@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2023

Codecov Report

Base: 95.60% // Head: 95.60% // No change to project coverage 👍

Coverage data is based on head (6280bf4) compared to base (9ffae59).
Patch has no changes to coverable lines.

❗ Current head 6280bf4 differs from pull request most recent head bd4257c. Consider uploading reports for the commit bd4257c to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2418   +/-   ##
=======================================
  Coverage   95.60%   95.60%           
=======================================
  Files         455      455           
  Lines        4550     4550           
  Branches      520      520           
=======================================
  Hits         4350     4350           
  Misses        128      128           
  Partials       72       72           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@leibale leibale merged commit 1be8422 into master Feb 21, 2023
@leibale leibale deleted the remove-unf-from-search-json-example branch February 21, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants